I'm not sure I'm following the point here. Yes, y=sin(2πn) is zero for any integer 'n'. So what? The replacement you did only applies at t = 0 and sin(0) = 0, so we expect the function to be zero at any integer multiple of anything that can be called a period away from t = 0.Hi again,
Well a function is periodic if:
y(t+Tp)=y(t)
but the period is Tp, so we have a secondary expression:
y(t+n*Tp)=y(t)
where 'n' is the number of periods, however Tp is still the actual period.
I guess that is why we say the period of sin(2*pi*f*t) is 1/f, yet we can still have "periods" (plural) of duration n/f.
To follow along with your calculation just to throw a little more math into it, if i start with y=sin(2*pi*f*t) and replace t with n/f (n an integer) i get:
y=sin(2*pi*n)
which is zero for any integer 'n'.
I also assume we are talking about simpler functions too here.
If we want the definition to have a preferred period, then we just need to incorporate that into the definition (something that is often done). At the same time, we need to patch up a bigger hole because the definition as you've given it here (and which is often the way it is given) means that EVERY function is periodic since if Tp = 0, every function satisfies the definition. Both of these are easy to deal with and the definition of periodicity is often found along the lines of the following:
A function is periodic if and only if a strictly positive value Tp exists such that
y(t+n*Tp)=y(t)
for every value 't' and every positive integer 'n'. The fundamental period of y(t) is the smallest value of Tp that satisfies this constraint.
This definition still has a weak spot for a DC signal since while there are infinitely many values of Tp that satisfy the constraint, the fundamental period is undefined but in the limit would be infinity. So to patch that up (which is done far less frequently) the definition would need to deal with this case explicitly, which when it is done, usually either simply excludes DC signals from consideration or defines the frequency of such a signal to be zero (by using a limiting process as a clearly periodic signal is reduced to a DC signal by letting the period grow to infinity such that y(t) = y(0) for any finite value of t). No matter what you do, the question of the periodicity of a DC signal is going to involve a kludge.