is this right should the resistor be before or after the the led's ie. the cathode end or anode end

 

hi 6666,
Welcome to AAC.
Your circuit is correct, but it is not good practice to connected LED's in parallel sharing a common current limiting resistor.
Most LED's do not have exactly the same same forward voltage drop.
E

 

Resistors do not have poles. U can place them in either location.

 

Ideally one resistor in series with each LED. The combinations can be paralleled.
The color of the LED affects the value of Vf used to calculate the series resistor.

 

so i should do this?

 

View attachment 147471 so i should do this?

Yes, sort of. The switch will only control the right most LED. The other two will be on constantly

 

View attachment 147471 so i should do this?

The handling of resistors for the LEDs is correct, and would also be ok with each resistor on the cathode instead of the anode - as long as each LED is in series with one resistor it won't matter which order they're in.

I'm curious about a different question: Is the switch where you want it?

In your first schematic, the LEDs would be on all the time, and the switch would only control the motor.

In your second schematic, two of the LEDs would be on all the time, and the motor and third LED would be controlled by the switch.

 

yea the switch has to be moved thanks for all your help =D

 

This should be ok