STM32 code inside while not working

yef smith · Feb 4, 2021

As you can see bellow my optimization is -O1

MrChips · Feb 4, 2021

In your code before the function definition, type:

#pragma O0

In IAR, the equivalent statement is:

#pragma optimize=none

djsfantasi · Feb 4, 2021

MrChips said:
In your code before the function definition, type:

#pragma O0

In IAR, the equivalent statement is:

#pragma optimize=none

I don’t really care, but why are we trying to teach the TS how to get bad code to work instead of teaching him the proper way to code this? Sure, it’s nice to be aware of how compiler/ linker optimization can adversely affect a program, but is this the teaching situation to use?

yef smith · Feb 4, 2021

I totally agree, so the proper way is counter

djsfantasi said:
I don’t really care, but why are we trying to teach the TS how to get bad code to work instead of teaching him the proper way to code this? Sure, it’s nice to be aware of how compiler/ linker optimization can adversely affect a program, but is this the teaching situation to use?

djsfantasi · Feb 4, 2021

yef smith said:
I totally agree, so the proper way is counter

No, the proper way is the delay() function, as first mentioned in post #10.

yef smith · Feb 4, 2021

Hello I fixed the problem by making loop variable volotile.
What do you think about such solution?
Thanks.

HenkjeJager · Feb 16, 2021

I also use a STM407 board and also STM401 boards.
I had the same problems with my first code.
Everything seems to be allright but the software starts to hang after a few instructions.
You must first create a startup code to configure the main clock.
Just attach the system_stm32f4xx.c and system_stm32f4xx.h and change some speed definitions in it and your software runs like a rat
Also the (startup) software for the external memory is in it so you don't have to rewrite it.

#define ARM_MATH_CM4 //own choice for yourself
#define STM32F401CC //define first your own controller type like stm407cc or something
#include <stm32f4xx.h>
#include <system_stm32f4xx.h>

main() {
SystemCoreClockUpdate();

//your code.....
}

And it's better to use the Bit-set and Bit-reset instruction.
But you must define it yourselfs because it's not in the stm407xx.h header.

#define GPIOD_BSRR (*((volatile unsigned long*)(GPIOD_BASE + 0x18)))

GPIOD_BSRR=GPIO_BSRR_BS_7 //bit 7 set
GPIOD_BSRR=GPIO_BSRR_BR_7 //bit 7 reset

yef smith · Feb 17, 2021

Hello ,When i put mytciks as volotile and made prescale by 10 of the counter frequency its started to work by the full code shown bellow.
SO i solved my problem.
The thing that i am missing is how to know from the RM of other document the limitations of the ISR?
Could you reccomend me some method of estimating the maximal frequency allowed for the ISR?
Thanks.

Code:

#include "main.h"
#include <stdio.h>
#include "string.h"
#include "stdlib.h"
#include "stdarg.h"
/* Private variables ---------------------------------------------------------*/
DAC_HandleTypeDef hdac;
volatile unsigned long myticks=0;

/* Private function prototypes -----------------------------------------------*/
void SystemClock_Config(void);
static void MX_GPIO_Init(void);
static void MX_DAC_Init(void);
/* USER CODE BEGIN PFP */

/* USER CODE END PFP */

/* Private user code ---------------------------------------------------------*/
/* USER CODE BEGIN 0 */

/* USER CODE END 0 */

/**
  * @brief  The application entry point.
  * @retval int
  */
    void delay(unsigned long us)
    {
      TIM4->CR1|=TIM_CR1_CEN;  
       
              myticks=0;
        while(myticks<us);
                //HAL_GPIO_TogglePin(GPIOD, GPIO_PIN_15);  
     TIM4->CR1&=~TIM_CR1_CEN;          
     
     
    }
void TIM4_IRQHandler(void)
{
    myticks++;
   
  TIM4->SR&=~TIM_SR_UIF;
}  
   
int main(void)
{
    RCC->APB1ENR|=RCC_APB1ENR_TIM4EN;
    TIM4->PSC=10;
    TIM4->ARR=21;
    TIM4->CR1|=TIM_CR1_URS;
    TIM4->DIER|=TIM_DIER_UIE;
    TIM4->EGR=TIM_EGR_UG;
   
    NVIC_EnableIRQ(TIM4_IRQn);
   HAL_Init();

   SystemClock_Config();

   MX_GPIO_Init();
  MX_DAC_Init();
  /* USER CODE BEGIN 2 */
//HAL_DAC_Start(&hdac,DAC_CHANNEL_1);
//HAL_DAC_SetValue(&hdac,DAC_CHANNEL_1,DAC_ALIGN_12B_R,1365);

     
   
  while (1)
  {
        delay(100000);
    HAL_GPIO_TogglePin(GPIOD, GPIO_PIN_14);
        //HAL_Delay(500);
         delay(100000);
        HAL_GPIO_TogglePin(GPIOD, GPIO_PIN_14);
       
        //HAL_Delay(500);
  }
  /* USER CODE END 3 */
}

/**
  * @brief System Clock Configuration
  * @retval None
  */
void SystemClock_Config(void)
{
  RCC_OscInitTypeDef RCC_OscInitStruct = {0};
  RCC_ClkInitTypeDef RCC_ClkInitStruct = {0};

  /** Configure the main internal regulator output voltage
  */
  __HAL_RCC_PWR_CLK_ENABLE();
  __HAL_PWR_VOLTAGESCALING_CONFIG(PWR_REGULATOR_VOLTAGE_SCALE1);
  /** Initializes the RCC Oscillators according to the specified parameters
  * in the RCC_OscInitTypeDef structure.
  */
  RCC_OscInitStruct.OscillatorType = RCC_OSCILLATORTYPE_HSE;
  RCC_OscInitStruct.HSEState = RCC_HSE_ON;
  RCC_OscInitStruct.PLL.PLLState = RCC_PLL_ON;
  RCC_OscInitStruct.PLL.PLLSource = RCC_PLLSOURCE_HSE;
  RCC_OscInitStruct.PLL.PLLM = 4;
  RCC_OscInitStruct.PLL.PLLN = 168;
  RCC_OscInitStruct.PLL.PLLP = RCC_PLLP_DIV2;
  RCC_OscInitStruct.PLL.PLLQ = 4;
  if (HAL_RCC_OscConfig(&RCC_OscInitStruct) != HAL_OK)
  {
    Error_Handler();
  }
  /** Initializes the CPU, AHB and APB buses clocks
  */
  RCC_ClkInitStruct.ClockType = RCC_CLOCKTYPE_HCLK|RCC_CLOCKTYPE_SYSCLK
                              |RCC_CLOCKTYPE_PCLK1|RCC_CLOCKTYPE_PCLK2;
  RCC_ClkInitStruct.SYSCLKSource = RCC_SYSCLKSOURCE_PLLCLK;
  RCC_ClkInitStruct.AHBCLKDivider = RCC_SYSCLK_DIV1;
  RCC_ClkInitStruct.APB1CLKDivider = RCC_HCLK_DIV8;
  RCC_ClkInitStruct.APB2CLKDivider = RCC_HCLK_DIV2;

  if (HAL_RCC_ClockConfig(&RCC_ClkInitStruct, FLASH_LATENCY_5) != HAL_OK)
  {
    Error_Handler();
  }
}

/**
  * @brief DAC Initialization Function
  * @param None
  * @retval None
  */
static void MX_DAC_Init(void)
{

  /* USER CODE BEGIN DAC_Init 0 */

  /* USER CODE END DAC_Init 0 */

  DAC_ChannelConfTypeDef sConfig = {0};

  /* USER CODE BEGIN DAC_Init 1 */

  /* USER CODE END DAC_Init 1 */
  /** DAC Initialization
  */
  hdac.Instance = DAC;
  if (HAL_DAC_Init(&hdac) != HAL_OK)
  {
    Error_Handler();
  }
  /** DAC channel OUT1 config
  */
  sConfig.DAC_Trigger = DAC_TRIGGER_NONE;
  sConfig.DAC_OutputBuffer = DAC_OUTPUTBUFFER_ENABLE;
  if (HAL_DAC_ConfigChannel(&hdac, &sConfig, DAC_CHANNEL_1) != HAL_OK)
  {
    Error_Handler();
  }
  /* USER CODE BEGIN DAC_Init 2 */

  /* USER CODE END DAC_Init 2 */

}

/**
  * @brief GPIO Initialization Function
  * @param None
  * @retval None
  */
static void MX_GPIO_Init(void)
{
  GPIO_InitTypeDef GPIO_InitStruct = {0};

  /* GPIO Ports Clock Enable */
  __HAL_RCC_GPIOH_CLK_ENABLE();
  __HAL_RCC_GPIOA_CLK_ENABLE();
  __HAL_RCC_GPIOD_CLK_ENABLE();

  /*Configure GPIO pin Output Level */
  HAL_GPIO_WritePin(GPIOD, GPIO_PIN_12|GPIO_PIN_13|GPIO_PIN_14|GPIO_PIN_15, GPIO_PIN_RESET);

  /*Configure GPIO pin : PA0 */
  GPIO_InitStruct.Pin = GPIO_PIN_0;
  GPIO_InitStruct.Mode = GPIO_MODE_INPUT;
  GPIO_InitStruct.Pull = GPIO_NOPULL;
  HAL_GPIO_Init(GPIOA, &GPIO_InitStruct);

  /*Configure GPIO pins : PD12 PD13 PD14 PD15 */
  GPIO_InitStruct.Pin = GPIO_PIN_12|GPIO_PIN_13|GPIO_PIN_14|GPIO_PIN_15;
  GPIO_InitStruct.Mode = GPIO_MODE_OUTPUT_PP;
  GPIO_InitStruct.Pull = GPIO_NOPULL;
  GPIO_InitStruct.Speed = GPIO_SPEED_FREQ_LOW;
  HAL_GPIO_Init(GPIOD, &GPIO_InitStruct);

}

/* USER CODE BEGIN 4 */

/* USER CODE END 4 */

/**
  * @brief  This function is executed in case of error occurrence.
  * @retval None
  */
void Error_Handler(void)
{
  /* USER CODE BEGIN Error_Handler_Debug */
  /* User can add his own implementation to report the HAL error return state */
  __disable_irq();
  while (1)
  {
  }
  /* USER CODE END Error_Handler_Debug */
}

#ifdef  USE_FULL_ASSERT
/**
  * @brief  Reports the name of the source file and the source line number
  *         where the assert_param error has occurred.
  * @param  file: pointer to the source file name
  * @param  line: assert_param error line source number
  * @retval None
  */
void assert_failed(uint8_t *file, uint32_t line)
{
  /* USER CODE BEGIN 6 */
  /* User can add his own implementation to report the file name and line number,
     ex: printf("Wrong parameters value: file %s on line %d\r\n", file, line) */
  /* USER CODE END 6 */
}
#endif /* USE_FULL_ASSERT */

MrChips · Feb 17, 2021

You should not move on until you resolve the first problem otherwise it will come back to haunt you.
Your oscilloscope is your #1 tool for diagnosing this type of problem.
I have shown you how to test your ISR. Stay focused on finding the fault that is causing the problem.
Set PSC = 0 and ARR = 1000.
Show the waveform obtained by the oscilloscope.

yef smith · Feb 23, 2021

Hello Mr chips,Code 1 the first code corresponds to 21 MHz APB1 CLOCK its PSC=5 ARR=7
and i am doing a delay(100) to create the steps shown bellow.

When i tried to change to PSC=0 and ARR=1000 as you said i got photo 2
When i tried to change to PSC=0 and ARR=1000 as you said i got photo3
So i cant see what caused the problem.
I'll be glad to know.

Code:

///   CODE 1

#include "main.h"


DAC_HandleTypeDef hdac;
volatile unsigned long myticks=0;

/* Private function prototypes -----------------------------------------------*/
void SystemClock_Config(void);
static void MX_GPIO_Init(void);
static void MX_DAC_Init(void);

    void delay(unsigned long us)
    {
      TIM4->CR1|=TIM_CR1_CEN;   
        
              myticks=0;
        while(myticks<us);
                //HAL_GPIO_TogglePin(GPIOD, GPIO_PIN_15);   
     TIM4->CR1&=~TIM_CR1_CEN;           
      
      
    }
void TIM4_IRQHandler(void)
{
    myticks++;
    
  TIM4->SR&=~TIM_SR_UIF;
}   

int main(void)
{
    
    RCC->APB1ENR|=RCC_APB1ENR_TIM4EN;
    TIM4->PSC=5;
    TIM4->ARR=7;
    TIM4->CR1|=TIM_CR1_URS;
    TIM4->DIER|=TIM_DIER_UIE;
    TIM4->EGR=TIM_EGR_UG;
    
    NVIC_EnableIRQ(TIM4_IRQn);
  /* USER CODE BEGIN 1 */

  /* USER CODE END 1 */

  /* MCU Configuration--------------------------------------------------------*/

  /* Reset of all peripherals, Initializes the Flash interface and the Systick. */
  HAL_Init();

  /* USER CODE BEGIN Init */

  /* USER CODE END Init */

  /* Configure the system clock */
  SystemClock_Config();

  /* USER CODE BEGIN SysInit */

  /* USER CODE END SysInit */

  /* Initialize all configured peripherals */
  MX_GPIO_Init();
  MX_DAC_Init();
  /* USER CODE BEGIN 2 */
HAL_DAC_Start(&hdac,DAC_CHANNEL_1);
//HAL_DAC_SetValue(&hdac,DAC_CHANNEL_1,DAC_ALIGN_12B_R,1365);

  /* USER CODE END 2 */

  /* Infinite loop */
  /* USER CODE BEGIN WHILE */
  while (1)
  {
    /* USER CODE END WHILE */
       HAL_DAC_SetValue(&hdac,DAC_CHANNEL_1,DAC_ALIGN_12B_R,0x00000000);
          // HAL_Delay(2);
        delay(100);
           HAL_DAC_SetValue(&hdac,DAC_CHANNEL_1,DAC_ALIGN_12B_R,0x00000400);
          // HAL_Delay(2);
        delay(100);
           HAL_DAC_SetValue(&hdac,DAC_CHANNEL_1,DAC_ALIGN_12B_R,0x00000800);
          // HAL_Delay(2);
        delay(100);
           HAL_DAC_SetValue(&hdac,DAC_CHANNEL_1,DAC_ALIGN_12B_R,0x00000C00);
         //  HAL_Delay(2);
        delay(100);
           HAL_DAC_SetValue(&hdac,DAC_CHANNEL_1,DAC_ALIGN_12B_R,0x00000FFF);
         //  HAL_Delay(2);
        delay(100);
           HAL_DAC_SetValue(&hdac,DAC_CHANNEL_1,DAC_ALIGN_12B_R,0x00000C00);
         //  HAL_Delay(2);
        delay(100);
           HAL_DAC_SetValue(&hdac,DAC_CHANNEL_1,DAC_ALIGN_12B_R,0x00000800);
         //  HAL_Delay(2);
         delay(100);
           HAL_DAC_SetValue(&hdac,DAC_CHANNEL_1,DAC_ALIGN_12B_R,0x00000400);
         //  HAL_Delay(2);
         delay(100);
    /* USER CODE BEGIN 3 */
  }
  /* USER CODE END 3 */
}

/**
  * @brief System Clock Configuration
  * @retval None
  */
void SystemClock_Config(void)
{
  RCC_OscInitTypeDef RCC_OscInitStruct = {0};
  RCC_ClkInitTypeDef RCC_ClkInitStruct = {0};

  /** Configure the main internal regulator output voltage
  */
  __HAL_RCC_PWR_CLK_ENABLE();
  __HAL_PWR_VOLTAGESCALING_CONFIG(PWR_REGULATOR_VOLTAGE_SCALE1);
  /** Initializes the RCC Oscillators according to the specified parameters
  * in the RCC_OscInitTypeDef structure.
  */
  RCC_OscInitStruct.OscillatorType = RCC_OSCILLATORTYPE_HSE;
  RCC_OscInitStruct.HSEState = RCC_HSE_ON;
  RCC_OscInitStruct.PLL.PLLState = RCC_PLL_ON;
  RCC_OscInitStruct.PLL.PLLSource = RCC_PLLSOURCE_HSE;
  RCC_OscInitStruct.PLL.PLLM = 4;
  RCC_OscInitStruct.PLL.PLLN = 168;
  RCC_OscInitStruct.PLL.PLLP = RCC_PLLP_DIV2;
  RCC_OscInitStruct.PLL.PLLQ = 4;
  if (HAL_RCC_OscConfig(&RCC_OscInitStruct) != HAL_OK)
  {
    Error_Handler();
  }
  /** Initializes the CPU, AHB and APB buses clocks
  */
  RCC_ClkInitStruct.ClockType = RCC_CLOCKTYPE_HCLK|RCC_CLOCKTYPE_SYSCLK
                              |RCC_CLOCKTYPE_PCLK1|RCC_CLOCKTYPE_PCLK2;
  RCC_ClkInitStruct.SYSCLKSource = RCC_SYSCLKSOURCE_PLLCLK;
  RCC_ClkInitStruct.AHBCLKDivider = RCC_SYSCLK_DIV1;
  RCC_ClkInitStruct.APB1CLKDivider = RCC_HCLK_DIV8;
  RCC_ClkInitStruct.APB2CLKDivider = RCC_HCLK_DIV2;

  if (HAL_RCC_ClockConfig(&RCC_ClkInitStruct, FLASH_LATENCY_5) != HAL_OK)
  {
    Error_Handler();
  }
}

/**
  * @brief DAC Initialization Function
  * @param None
  * @retval None
  */
static void MX_DAC_Init(void)
{

  /* USER CODE BEGIN DAC_Init 0 */

  /* USER CODE END DAC_Init 0 */

  DAC_ChannelConfTypeDef sConfig = {0};

  /* USER CODE BEGIN DAC_Init 1 */

  /* USER CODE END DAC_Init 1 */
  /** DAC Initialization
  */
  hdac.Instance = DAC;
  if (HAL_DAC_Init(&hdac) != HAL_OK)
  {
    Error_Handler();
  }
  /** DAC channel OUT1 config
  */
  sConfig.DAC_Trigger = DAC_TRIGGER_NONE;
  sConfig.DAC_OutputBuffer = DAC_OUTPUTBUFFER_ENABLE;
  if (HAL_DAC_ConfigChannel(&hdac, &sConfig, DAC_CHANNEL_1) != HAL_OK)
  {
    Error_Handler();
  }
  /* USER CODE BEGIN DAC_Init 2 */

  /* USER CODE END DAC_Init 2 */

}

/**
  * @brief GPIO Initialization Function
  * @param None
  * @retval None
  */
static void MX_GPIO_Init(void)
{
  GPIO_InitTypeDef GPIO_InitStruct = {0};

  /* GPIO Ports Clock Enable */
  __HAL_RCC_GPIOH_CLK_ENABLE();
  __HAL_RCC_GPIOA_CLK_ENABLE();
  __HAL_RCC_GPIOD_CLK_ENABLE();

  /*Configure GPIO pin Output Level */
  HAL_GPIO_WritePin(GPIOD, GPIO_PIN_12|GPIO_PIN_13|GPIO_PIN_14|GPIO_PIN_15, GPIO_PIN_RESET);

  /*Configure GPIO pins : PD12 PD13 PD14 PD15 */
  GPIO_InitStruct.Pin = GPIO_PIN_12|GPIO_PIN_13|GPIO_PIN_14|GPIO_PIN_15;
  GPIO_InitStruct.Mode = GPIO_MODE_OUTPUT_PP;
  GPIO_InitStruct.Pull = GPIO_NOPULL;
  GPIO_InitStruct.Speed = GPIO_SPEED_FREQ_LOW;
  HAL_GPIO_Init(GPIOD, &GPIO_InitStruct);

}

/* USER CODE BEGIN 4 */

/* USER CODE END 4 */

/**
  * @brief  This function is executed in case of error occurrence.
  * @retval None
  */
void Error_Handler(void)
{
  /* USER CODE BEGIN Error_Handler_Debug */
  /* User can add his own implementation to report the HAL error return state */
  __disable_irq();
  while (1)
  {
  }
  /* USER CODE END Error_Handler_Debug */
}

#ifdef  USE_FULL_ASSERT
/**
  * @brief  Reports the name of the source file and the source line number
  *         where the assert_param error has occurred.
  * @param  file: pointer to the source file name
  * @param  line: assert_param error line source number
  * @retval None
  */
void assert_failed(uint8_t *file, uint32_t line)
{
  /* USER CODE BEGIN 6 */
  /* User can add his own implementation to report the file name and line number,
     ex: printf("Wrong parameters value: file %s on line %d\r\n", file, line) */
  /* USER CODE END 6 */
}
#endif /* USE_FULL_ASSERT */

/************************ (C) COPYRIGHT STMicroelectronics *****END OF FILE****/

MrChips · Feb 23, 2021

You need to stay focused and test the ISR by itself.

C:

void TIM4_IRQHandler(void)
{ 
  TIM4->SR = 0;
  HAL_GPIO_TogglePin(GPIOD, GPIO_PIN_15);
}  

void main(void)
{
   Init();
   while(1);
}

Thread starter	Similar threads	Forum	Replies	Date
S	STM32F302K8 driven system with 4 pin header programming	Microcontrollers	2	Feb 23, 2024
	Atomicity of STM32 register writes	Microcontrollers	3	Feb 14, 2024
	compiling Arduino code to stm32	Programming & Languages	3	Jul 15, 2022
C	stm32f103c8t6 st-link connected but failing to upload code	Microcontrollers	7	Jun 25, 2021
B	STM32 SPI not operating - unable to determine error in code	Microcontrollers	12	Mar 3, 2020

STM32 code inside while not working

Join our Engineering Community! Sign-in with:

STM32 code inside while not working

yef smith

MrChips

djsfantasi

yef smith

djsfantasi

yef smith

HenkjeJager

yef smith

MrChips

yef smith

MrChips

You May Also Like

Building a Handheld Retro Gaming Console With Local Wireless Connectivity

ST Drops Two Time-of-Flight Sensors for 3D Depth Sensing

Microchip Expands Its Serial SRAM Devices to 2 Mb and 4 Mb

Special Feature: Connectors Eye High Density and Performance