Hi Guys

I'm trying to enable PWM on the pic10f322.I've gotten it up and running but I'm having trouble setting the duty cycle.

It's outputting at 38khz as it should but the duty cycle is stuck at 90%. In fact no matter what I put in PWM2DCH and PWM2DCL, even if i zero those out, it's still 90% so i assume I've made a screwed on the initialization.

It's a basic setup, this is what I have:

#include	<htc.h>


#define _XTAL_FREQ 8000000

//__CONFIG (FOSC_INTOSC & BOREN_OFF &  WDTE_OFF & PWRTE_OFF & MCLRE_OFF & CP_OFF & LVP_OFF & LPBOR_OFF & BORV_HI & WRT_OFF);

#pragma config FOSC = INTOSC    // Oscillator Selection bits (INTOSC oscillator: CLKIN function disabled)
#pragma config BOREN = OFF      // Brown-out Reset Enable (Brown-out Reset disabled)
#pragma config WDTE = OFF       // Watchdog Timer Enable (WDT disabled)
#pragma config PWRTE = OFF      // Power-up Timer Enable bit (PWRT disabled)
#pragma config MCLRE = ON       // MCLR Pin Function Select bit (MCLR pin function is digital input, MCLR internally tied to VDD)
#pragma config CP = OFF         // Code Protection bit (Program memory code protection is disabled)
#pragma config LVP = ON         // Low-Voltage Programming Enable (Low-voltage programming enabled)
#pragma config LPBOR = OFF      // Brown-out Reset Selection bits (BOR disabled)
#pragma config BORV = LO        // Brown-out Reset Voltage Selection (Brown-out Reset Voltage (Vbor), low trip point selected.)
#pragma config WRT = OFF        // Flash Memory Self-Write Protection (Write protection off)




void InitPWM();



void main()
{

    PORTA = 0b00000000;
    TRISA = 0b00000111;
    ANSELA = 0b00000000;

     InitPWM();



      while(1)
      {
    
      }
      
 }



void InitPWM()
{

   
    PWM2CON = 0b00000000;   // Clear PWM1CON
    PR2   = 0b00110100;     // Set period to  52



    PWM2CON = 0b11000000;   //Enable PWM Module Enable and Module Output Enable bit

    PWM2DCH = 0b00000000;   // Clear duty cycle registers
    PWM2DCL = 0b00000000;


    TMR2IF = 0;             //Clear the timer 2 interrupt flag
    T2CON = 0b00000000;     //Set prescaler to 1 (T2CKPS<1:0>), enable to off(TMR2ON)
                            //and postscaler to 1:1(TOUTPS 3:0)
 
   TMR2ON = 1;              //Now enable timer 2 
 

    TRISA = 0b00000000;     //Enable the pwm pin output driver on RA1 (and also make all other pins outpouts.)



//Set duty cycle to 50%

    PWM2DCH = 0b11010000 ;
    PWM2DCL = 0b10000000;
    

    return;
 }


 }

It's probably something simple, but I've been staring at this for a couple of hours and I'm starting to go cross eyed. Anyone point out what I'm doing wrong?

 

I can't give you specific help, but I would look at all the registers on page 112 of the datasheet that are associated with PWM.

 

Oops... seems you've tried this already. Dang Never mind (left it here anyway)

Well since you linked to the data sheet I just had to help <s>

You set the duty cycle to 110100001 = 0x1A1 = 417, which is about 82% of 511 (max duty cycle setting)

Try making the duty just 511/2 = 255 = 0xFF or

    PWM2DCH = 0b01111111;
    PWM2DCL = 0b10000000;

 

Thanks for the input. Yeah 417 was just the last value I happened to have in there, but the output is 90% regardless of the value.

 

I think its this.

At 8MHz, Tosc is 125ns, Tcyc=4*Tosc=500ns.
With PR2=52decimal, prescaler=1, the PWM period is Tcyc(PR2+1) = 500ns*53 = 26.5us.
For 50% duty cycle, the duty cycle registers must count off 26.5us/2=13.25us.
PulseWidth = PWMxDCH/L (10bits) * Tosc * 1(prescaler) giving
13.25us/125ns=PWMxDCH/L = 106decimal = 0001101010 to 10 bits. Splitting this gives
PWMxDCH = 00011010 and PWMxDCL = 10xxxxxx. So:
PWMxDCH = 1ah
PWMxDCL = 80h

Checking:
Duty Cycle Ratio = PWMxDCHL / 4(PR2+1) = 104/212 = .4905 ~=50%

You might want to play around with PR2 to get it it exact.

Hope this works for you, I just got my 10F322 stuff yesterday and need the pwm too.
EDIT: Rechecked it on the spreadsheet and the numbers match other midrange PWMs. Should be good to go.
EDIT2: It also says you are getting only 7.73 bits of resolution due to the small PR2 value.

EDIT3: PWM2 goes to RA1 but you have it TRIS'd to an input. Also, review the port setup to make sure you don't have the pin assigned to any of the several other functions that it can have (CLC, CWG1B etc.). Especially ensure that the complementary waveform generator is disabled. It has a higher pin priority than the PWM. Since its a weird problem and this is a new chip, I would look at the disassembled compiler output to ensure that it is properly setting the banks etc.

 

Well, got it working.

John, your math looked similar to what I had initially calculated but to be sure I ran through the setup again with your numbers but it made no difference, nor did explicitly disabling the other functions on the pins.

In the end I just threw away the program and started again and did it line by line checking everything as i went - and it worked. I guess I must have had a bit transposed somewhere despite all my checking.

When I finish banging my head off my desk I'll continue with the program!


Thanks for the help guys.

 

Oh and just in case anyone is looking for a working example in the future:

/*  38khz pwm on RA1 with 50% duty cycle. 
   
   Timer 2 is is 52 decimal
   Prescaler is 1
   Duty cycle value is 106 decimal                 */

#include	<htc.h>


#define _XTAL_FREQ 8000000

//__CONFIG (FOSC_INTOSC & BOREN_OFF &  WDTE_OFF & PWRTE_OFF & MCLRE_OFF & CP_OFF & LVP_OFF & LPBOR_OFF & BORV_HI & WRT_OFF);

#pragma config FOSC = INTOSC    // Oscillator Selection bits (INTOSC oscillator: CLKIN function disabled)
#pragma config BOREN = OFF      // Brown-out Reset Enable (Brown-out Reset disabled)
#pragma config WDTE = OFF       // Watchdog Timer Enable (WDT disabled)
#pragma config PWRTE = OFF      // Power-up Timer Enable bit (PWRT disabled)
#pragma config MCLRE = ON       // MCLR Pin Function Select bit (MCLR pin function is digital input, MCLR internally tied to VDD)
#pragma config CP = OFF         // Code Protection bit (Program memory code protection is disabled)
#pragma config LVP = ON         // Low-Voltage Programming Enable (Low-voltage programming enabled)
#pragma config LPBOR = OFF      // Brown-out Reset Selection bits (BOR disabled)
#pragma config BORV = LO        // Brown-out Reset Voltage Selection (Brown-out Reset Voltage (Vbor), low trip point selected.)
#pragma config WRT = OFF        // Flash Memory Self-Write Protection (Write protection off)




void InitPWM();


void main()
{

    PORTA = 0b00000000;
    TRISA = 0b00000000;
    ANSELA = 0b00000000;
    CLC1CON = 0b00000000;
    CWG1CON0 = 0b00000000;

    
     InitPWM();

      while(1)
      {
    
      }
      
 }



void InitPWM()
{
  
    PWM2CON = 0b00000000;   // Clear PWM1CON
    PR2   = 0b00110100;     // Configure the Timer2 period - decimal 52

 

    PWM2CON = 0b11000000;   //Enable PWM Module, Module Output

    PWM2DCH = 0b00000000;   // Clear duty cycle registers
    PWM2DCL = 0b00000000;


    TMR2IF = 0;             //Clear the timer 2 interrupt flag 
    T2CON = 0b00000000;     //Set prescaler to 1 
                            
    TMR2ON = 1;             //Enable timer 2 
 

    TRISA=0b00000000; =	    //Enable the pwm pin output


    //Set duty cycle to 106 
    PWM2DCH = 0b00011010;
    PWM2DCL = 0b10000000;

   

    return;
 }

 

Not sure whether its transposed bits or not but the resulting math wasn't right in the original code. Glad we agree on the new figures.

To dispel any mysteries, in the second code I do see that there are important differences compared to the original. Notably, TRISA is set for outputs. Sometimes, enabling a peripheral configures the pin direction but other times it doesn't - depends on the peripheral, the PIC and the documentation (which can be confusing and on occasion incorrect). While some may argue the point, I always set the directions to match the peripherals. The bonus is that if you ever have to disable/re-enable the peripheral (sometimes necessary to recover from errors) you don't lose control of the pin.

You've also explicitly disabled the other functions that share the pin rather than rely on the power-up defaults. A few times on these boards, such fixes have resolved problems similar to yours. I personally think it's always a good idea and always do it in my own code. Explicitly initializing all things is also necessary if you need to be able to do a warm restart.

Glad you got it working. If you get a chance, it might be instructive to revert to the original code step by step to see what the root of the problem was. I'd be interested in knowing what you find.

Have fun!