Hi,
The signal polarity looks OK.
The 1K's are too high in value, I would suggest 270R or 330R in order to get a fast/hard switch On of the Emitter LED's.
Looks good. What baud rate are you planning on using ? If it's high then I suggest you check out the datasheet of the optocoupler to make sure that it has fast enough rise/fall times because last optocoupler that I worked with was pretty slow. This could (potentially) be a problem to you but most likely not.